Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distribution dependency #64

Closed
wants to merge 1 commit into from

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Jan 21, 2016

a bit more structure, inspired by #61

e.g. hpack could optionally add upper bounds considering local package database.

@mgsloan
Copy link
Contributor

mgsloan commented Jan 21, 2016

Nice! The Cabal dep will also be needed for #63

@phadej phadej force-pushed the distribution-dependency branch 2 times, most recently from daa2176 to 29247fb Compare February 26, 2016 08:27
@phadej phadej force-pushed the distribution-dependency branch from 29247fb to ba0fef2 Compare May 10, 2016 15:00
@phadej
Copy link
Contributor Author

phadej commented May 10, 2016

Rebased on current master

@phadej
Copy link
Contributor Author

phadej commented May 23, 2016

ping @sol, any opinions on this pr?

@mitchellwrosen
Copy link
Collaborator

@sol, are you still maintaining this? I have a couple (super minor) pull requests up, and this has been up since January with no comment from you.

Nothing wrong with being too busy - we all are - but let us know!

@sol
Copy link
Owner

sol commented Aug 14, 2016

My resources are very limited. This is why I have to prioritize carefully.

This PR didn't make it to the top of my list. I'm sorry for that.

If somebody thinks this is critical for some reason and needs it now, then please make a case.

@sol
Copy link
Owner

sol commented Aug 14, 2016

@mitchellwrosen if you want to help moving things forward, help with #122 much appreciated.

@mitchellwrosen
Copy link
Collaborator

No need to apologize, just asking for clarification. I'll go through some issues tomorrow; I use hpack often enough that I should give back =)

@sol
Copy link
Owner

sol commented Sep 7, 2016

Hey guys, sorry for being lazy on on this. I'm happy to consider a patch like this at the point it provides actual user value. But until the point we really need it I would like to avoid the Cabal dependency.

I am closing this for now, but please don't be shy to open an other pull request at the point you have a use case.

@sol sol closed this Sep 7, 2016
@phadej
Copy link
Contributor Author

phadej commented Sep 7, 2016

Use cases: add / modify dependency bounds inside hpack. Haven't done that in this PR, because didn't wanted to have too big PR.

@phadej
Copy link
Contributor Author

phadej commented Sep 7, 2016

OTOH, I see that #61 is implemented. Probably using own parser / formatter?

@phadej phadej deleted the distribution-dependency branch February 6, 2017 07:17
sol added a commit that referenced this pull request Sep 23, 2017
sol added a commit that referenced this pull request Sep 23, 2017
sol added a commit that referenced this pull request Sep 23, 2017
sol added a commit that referenced this pull request Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants