Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bilibili - Failed to download all videos from one channel #2685

Closed
wants to merge 2 commits into from
Closed

Bilibili - Failed to download all videos from one channel #2685

wants to merge 2 commits into from

Conversation

ooooo999
Copy link

In the case when there are more than 100 videos uploaded by one Bilibili user, running "you-get [URL]" or "you-get -l [URL]" will only download the latest 100 videos.

Debug shows that the refactor turns to url (https://space.bilibili.com/ajax/member/getSubmitVideos?mid=19111402&page=1&pagesize=100&order=0&jsonp=jsonp) .
Looked into source codes. The value of page=1 and pagesize=100 are somewhat hard-coded. Tried changing pagesize to 200 returns an error.
Possible approach is 1)to somehow fix the error and allow it to download all videos from the up-loader no matter how many they are, or 2)add a command line option/parameter for user to specify the page that he's trying to start downloading from.

Test case:
you-get https://space.bilibili.com/19111402/video
you-get -l https://space.bilibili.com/19111402/video

Test case for downloading all videos from bilibili channel, where the extractor only output the latest 100 videos when there's more.
@soimort-bot
Copy link
Collaborator

Hello @ooooo999,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

@soimort soimort closed this in e1ca6b0 Feb 26, 2019
@ooooo999 ooooo999 deleted the bilibili-download-all-videos branch February 27, 2019 02:37
@sovereign000
Copy link

you-get https://space.bilibili.com/479372369/video -l can not work!

File "k:\software\python38\lib\site-packages\you_get\extractors\bilibili.py", line 737, in download_playlist_by_url
pc = videos_info['data']['pages']
TypeError: string indices must be integers

@qchenac
Copy link

qchenac commented Mar 6, 2021

This problem still not addressed yet. Really need to expand the limit to 200 or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants