Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tildes #746

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Remove tildes #746

merged 1 commit into from
Sep 11, 2020

Conversation

CucumisSativus
Copy link
Contributor

According to akka doc

Gotcha: forgetting the ~ (tilde) character in between directives can result in perfectly valid Scala code that compiles but does not work as expected. What would be intended as a single expression would actually be multiple expressions, and only the final one would be used as the result of the parent directive. Because of this, the recommended way to compose routes is with the the concat combinator.

So i changed all tildes into concats

@adamw adamw merged commit 9915447 into softwaremill:master Sep 11, 2020
@adamw
Copy link
Member

adamw commented Sep 11, 2020

Thanks! :) I wasn't aware of this change-of-recommendation, TIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants