Fix OpenAPI constraints for array schemas #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot that well versed in scala yet.
This prevents the enum: validator being attached on the array level in OpenAPI yaml.
In the case of array schemas, the constraints of the array elements were being attached to the array itself when generating the OpenAPI descriptions. This is fixed by not extracting validators out of CollectionElements validator when the schema is equal to SArray, and extracting all validators otherwise.
|
Released in 0.16.13, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #657
Turns out the bug is more general, and not limited to arrays of enums.
In the case of array schemas, the constraints of the array elements were being attached to the array itself when generating the OpenAPI descriptions.
This is fixed by not extracting validators out of CollectionElements validator when the schema is equal to SArray, and extracting all validators otherwise. Added an additional test that validates an array of ints to prove the solution.