Enable Scala 3 build for Play 2.9 Server #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 3, 2024 10:11
Build pulls in Scala 3 versions of Akka dependencies, but akka-http-core was only published for 2.13. One needs to exclude all Scala 3 Akka artefacts and use them via CrossVersion.for3Use2_13.
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back when we added the Play 2.9 module (#3313), the tests for Scala 3 failed and so it was removed.
Now, however, we'd like to move to Scala 3 and so this PR re-enables the Scala 3 build, fixing the dependency issues.
It seems like Scala 3 artifacts for Akka are pulled in, but akka-http-core was never published for Scala 3 and so these different binary versions clash.
Following the official guide, I excluded all the relevant native Scala 3 dependencies and replaced them with
for3Use2_13ones.