Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shutdowns in test servers #3930

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Fix shutdowns in test servers #3930

merged 3 commits into from
Jul 14, 2024

Conversation

kciesielski
Copy link
Member

@kciesielski kciesielski commented Jul 12, 2024 •
edited
Loading

Instead of defining serverWithStop and deriving server on top of it, each backend's test interpreter will now do the opposite: define server, which returns a Resource[IO, Port], then use this in base serverWithStop.

@kciesielski kciesielski marked this pull request as ready for review July 12, 2024 20:18
@kciesielski kciesielski requested a review from adamw July 12, 2024 20:18
@adamw adamw merged commit 5a51c11 into master Jul 14, 2024
27 checks passed
@adamw adamw deleted the fix-testinterpreter-stop branch July 14, 2024 15:57
@adamw
Copy link
Member

adamw commented Jul 14, 2024

Nicely simplified :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamw adamw Awaiting requested review from adamw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kciesielski @adamw