Fixes in iron: union, intersection, Not[Empty] and other cases #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
changed the title
kciesielski
commented
Jun 18, 2024
integrations/iron/src/main/scala/sttp/iron/codec/iron/TapirCodecIron.scala
Show resolved
Hide resolved
adamw
reviewed
Jun 19, 2024
integrations/iron/src/main/scala/sttp/iron/codec/iron/IntersectionTypeMirror.scala
Outdated
Show resolved
Hide resolved
adamw
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3830
This PR fixes some bugs in iron integration:
MinLengthbecomeDescribedAs[Length[GreaterEqual[0]]], _]. This made our validator resolution fail.summonFrom, resulting in wrong validators being resolvedThese fixes should cover cases of problematic schema resolution for types with constrains like
DescribedAs,String :| Not[Empty], unions, intersections, and possibly some other cases.