Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix flaky tests #3827

Draft
wants to merge 85 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
0a9e3ad
Add tracing for tests
kciesielski Jun 6, 2024
f97d3e7
Don't for in tests for NettySync
kciesielski Jun 7, 2024
4c37ef6
Run tests on JVM21
kciesielski Jun 7, 2024
53ce6d1
Disable vert.x tests for maxContentLength
kciesielski Jun 7, 2024
4cbe640
Merge branch 'master' into fix-hanging-tests
kciesielski Jun 14, 2024
c72ea72
Disable client tests
kciesielski Jun 14, 2024
830be26
Return a more standard message
kciesielski Jun 14, 2024
235ced3
Don't check Close frame when it can fail (vertx)
kciesielski Jun 14, 2024
682b158
Restore after merge
kciesielski Jun 14, 2024
055c5e0
Merge branch 'master' into fix-hanging-tests
kciesielski Jun 14, 2024
0d1cb9b
Restore Java 11 builds
kciesielski Jun 14, 2024
96efdc8
Restore fork needed for running perf test server
kciesielski Jun 14, 2024
5359d41
Disable graceful shutdown tests
kciesielski Jun 14, 2024
6440174
Disable tests for zio-based backends
kciesielski Jun 14, 2024
c4e2904
Bring back testServer and two zio backends
kciesielski Jun 17, 2024
44f12f2
Fix build
kciesielski Jun 17, 2024
6f5daf2
Hide http4s-zio to check if armeria-zio fails
kciesielski Jun 17, 2024
e036510
Restore http4sZio
kciesielski Jun 18, 2024
61daec2
Disable WebSocket tests for http4s-zio
kciesielski Jun 18, 2024
ff4b9ae
Restore zhtt4p4s WS tests, disable vertx-cats
kciesielski Jun 20, 2024
0fb69ae
Keep only vertx-cats disabled
kciesielski Jun 24, 2024
35b9d8d
Merge branch 'master' into fix-hanging-tests
kciesielski Jun 24, 2024
66d0799
Disable tests for vertx-zio
kciesielski Jun 24, 2024
e7dd9ab
Experiment: publish compiled code as an image
kciesielski Jul 8, 2024
952f37b
Fix references
kciesielski Jul 8, 2024
0cf5edb
Add a dockerfile
kciesielski Jul 8, 2024
7dfdac7
Install additional tools on the test image
kciesielski Jul 8, 2024
1fa2f61
Fix dockerfile
kciesielski Jul 8, 2024
ab5025e
Limit matrices for faster experimenting
kciesielski Jul 8, 2024
5be2f45
Remove workdir
kciesielski Jul 8, 2024
75df48c
Fix the matrix
kciesielski Jul 8, 2024
5aff159
Fix compileScoped command
kciesielski Jul 8, 2024
abd0ab7
Mount workdir
kciesielski Jul 8, 2024
b72fce4
Disable build cache from GH Action
kciesielski Jul 8, 2024
eee3fdd
Try different base image for tests
kciesielski Jul 8, 2024
a352599
Try the gh actions runner base image
kciesielski Jul 8, 2024
d1f32ba
Remove run npm step
kciesielski Jul 8, 2024
beac067
Manually set up sbt
kciesielski Jul 9, 2024
fbcae65
Run installdependencies.sh
kciesielski Jul 9, 2024
5c95e1e
Install deps as root
kciesielski Jul 9, 2024
dae3523
Install curl manually
kciesielski Jul 9, 2024
7f7d820
Fix apt calls
kciesielski Jul 9, 2024
e692177
Fix apt upgrade
kciesielski Jul 9, 2024
485c0aa
Install unzip
kciesielski Jul 9, 2024
99b3318
Disable retry
kciesielski Jul 9, 2024
5b44599
Set all workspace files as owned by runner
kciesielski Jul 9, 2024
32ba788
Add some checks
kciesielski Jul 9, 2024
63e0c46
Remove some stuff from Dockerfile
kciesielski Jul 9, 2024
8f6f709
Debug workdir
kciesielski Jul 9, 2024
efa067f
Try a different workdir
kciesielski Jul 9, 2024
2e1e73c
Move sources to workdir
kciesielski Jul 9, 2024
2eb77aa
Try a different way of moving
kciesielski Jul 9, 2024
5ed1af1
Switch default shell to bash
kciesielski Jul 9, 2024
4c8000a
Copy build results
kciesielski Jul 9, 2024
5cf767e
Use context to make changes visible
kciesielski Jul 9, 2024
99578bb
Drop dockerization, use build-group axis
kciesielski Jul 9, 2024
9277b03
Force zio only for experimentation, disable netty-zio
kciesielski Jul 9, 2024
b1d6868
Disable zio-http
kciesielski Jul 9, 2024
0480fa7
Reduce retries for faster feedback
kciesielski Jul 9, 2024
9e7ac71
Remove the JS platform temporarily
kciesielski Jul 9, 2024
fe6c8be
Restore jdk 11 for Mima
kciesielski Jul 9, 2024
6998880
Don't expect close response for zhttp4s ws tests (flaky)
kciesielski Jul 9, 2024
a1f27d7
Attempt a thread dump on retry
kciesielski Jul 9, 2024
e8d23ff
Leave disabled tests only for netty-zio
kciesielski Jul 9, 2024
2604d67
Tune attempts/retries for better feedback
kciesielski Jul 9, 2024
40a9d3f
Include missing matrix combinations
kciesielski Jul 9, 2024
bf45f53
Fix saving pid
kciesielski Jul 9, 2024
b59591a
use pkill instead of pidfile
kciesielski Jul 9, 2024
63d3b4d
Try a different hack to pkill java
kciesielski Jul 9, 2024
894e6ee
Fork tests for netty-zio and zio-http
kciesielski Jul 10, 2024
35d261b
Remove test forks
kciesielski Jul 10, 2024
5de2a9b
Run kill switch when closing server
kciesielski Jul 10, 2024
e7bb1a2
Remove the pkill hack
kciesielski Jul 10, 2024
b97599e
Fork tests for zio-http
kciesielski Jul 10, 2024
ff8d3b1
Restore longer timeout
kciesielski Jul 10, 2024
4312db0
Restore short timeout
kciesielski Jul 10, 2024
9898c8f
Revert test fork
kciesielski Jul 10, 2024
e403e94
Restore pkill to get thread dumps
kciesielski Jul 10, 2024
0041cab
Run on bash, try different dump technique
kciesielski Jul 10, 2024
a001a0c
Add pkill to on_retry_command as well
kciesielski Jul 10, 2024
9e23e3d
Disable graceful shutdown
kciesielski Jul 10, 2024
69212ad
Restore graceful shutdown
kciesielski Jul 10, 2024
bb1d898
Add pkill to 2.12
kciesielski Jul 10, 2024
3fdf9f9
Disable additionalTests
kciesielski Jul 10, 2024
636655d
Remove pkill
kciesielski Jul 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try the gh actions runner base image
kciesielski committed Jul 8, 2024

Verified

This commit was signed with the committer’s verified signature.
kciesielski Krzysztof Ciesielski
commit a352599a77297b13cd39600e404d9d2db395ab74
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Use Ubuntu 22.04 as the base image
FROM node:20
FROM ghcr.io/actions/actions-runner

# Avoid prompts from apt
ENV DEBIAN_FRONTEND=noninteractive