ZIO HTTP Server should not fold multiple Set-Cookie headers #3723
Conversation
This change makes the behaviour of handling multiple Set-Cookie headers consistent among multiple server backends. See #3654 for more details.
|
|
||
| def tests(): List[Test] = requestTests | ||
|
|
||
| val requestTests = List( |
There was a problem hiding this comment.
suggestion: Since this is ZIO-specific, it could go directly to ZioHttpServerTest.additionalTests() and you won't need the cookieHeaders flag.
There was a problem hiding this comment.
I though it might be good to do the way it's currently done, since it does not only reproduce the ZIO-specific bug but also guard consistency among different backends' behaviour. Disclaimer: I do not have a strong opinion on this, I just want to put a spotlight on my initial motivation.
There was a problem hiding this comment.
yeah let's test it in all backends, as we want all backends to behave this way (separating the headers)
There was a problem hiding this comment.
Sorry, I didn't notice the flag is always true, so this means this test is executed for all the servers, right? In that case, I second Adam's opinion that the flag could be removed. And disregard my comment about moving the test to ZioHttpServerTest.
| @@ -28,7 +28,8 @@ class AllServerTests[F[_], OPTIONS, ROUTE]( | |||
| oneOfBody: Boolean = true, | |||
| cors: Boolean = true, | |||
| options: Boolean = true, | |||
| maxContentLength: Boolean = true | |||
| maxContentLength: Boolean = true, | |||
| cookieHeaders: Boolean = true | |||
There was a problem hiding this comment.
if this is always enabled, I guess we can drop the flag?
This change makes the behaviour of handling multiple Set-Cookie headers consistent among multiple server backends.
See #3654 for more details.