Rename netty-server-loom to netty-server-sync #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
force-pushed
the
netty-sync-module
branch
from
c3d8003 to
dc7a22b
Compare
adamw
approved these changes
Apr 19, 2024
kciesielski
commented
Apr 19, 2024
| @@ -249,8 +249,14 @@ lazy val rawAllAggregates = core.projectRefs ++ | |||
| derevo.projectRefs ++ | |||
| awsCdk.projectRefs | |||
|
|
|||
| def buildWithLoom(project: String): Boolean = | |||
| project.contains("Loom") || project.contains("nima") || project.contains("perfTests") || project.contains("examples3") | |||
| lazy val loomProjects: Seq[String] = Seq(nettyServerSync, nimaServer, examples).flatMap(_.projectRefs).flatMap(projectId) | |||
There was a problem hiding this comment.
perfTests no longer have to be built with loom, because I moved sync server runner out of it (because of Scala 3 because of Ox :)
kciesielski
commented
Apr 19, 2024
| // needed because of https://github.com/coursier/coursier/issues/2016 | ||
| useCoursier := false, | ||
| Test / run / fork := true, | ||
| libraryDependencies ++= Seq( | ||
| "com.softwaremill.ox" %% "core" % Versions.ox, | ||
| "org.reactivestreams" % "reactive-streams-tck" % Versions.reactiveStreams % Test, |
There was a problem hiding this comment.
These 2 deps (reactive-streams-tck and weaver) were added during development of netty-loom websockets but are not needed after all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.