Avoid generic type in Netty's RunAsync #3529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
apply
method inRunAsync
takes an unnecessary type parameter. Kyo allows nesting of effects for composition but it's necessary to prove that a computation isn't nested to invoke methods that handle effects, which is necessary forRunAsync
's implementation. I'm currently using an unsafe flat check to work this around.Solution
Modify
RunAsync.apply
to take a anF
fixed toUnit
, which Kyo is able to prove as flat and matches the usage inNettyBodyListener
.Notes
Referring to non-existent class sttp.apispec.SchemaType
but I imagine isn't related to the change.