Improvements to the performance testing harness #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
commented
Jan 26, 2024
| object VanillaServer extends ServerRunner { override def start = VertxRunner.runServer(Vanilla.route(1)) } | ||
| object VanillaMultiServer extends ServerRunner { override def start = VertxRunner.runServer(Vanilla.route(127)) } |
There was a problem hiding this comment.
issue: This is strange, SimpleGetMultiRoute tests should have been failing with 127 endpoints. I need to re-run them and double check the results now.
There was a problem hiding this comment.
because you've been hitting endpoint 127 and they had numbers 0..126? :)
There was a problem hiding this comment.
Yeah :) But Gatling still logs throughput, even if it gets 404s ;)
There was a problem hiding this comment.
maybe we can expect 200 in the scenario?
adamw
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pekko.*,vertx.future.*, etc.*for running all servers - there's too many of them anyway