Performance tests: Fix warm-up phase #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't gatling have a built-in notion of "warmup" which would be filtered out? |
|
It doesn't, I only found that it has built-in warm-up for its HTTP client which is warmed up by sending requests to https://gatling.io |
|
Ah, sending reqs to gatling.io isn't going to work for us ;) |
adamw
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current way of warming-up backends has a few downsides. Here's a proposition of improvements. Instead of running
warmupScenario.andThen(actualScenario)we run Gatling twice with just theactualScenariobut different parameters. This gives correct Gatling reports in the end, right now these reports are tainted with warmup data and unusable.Our aggregated reports were correct because we were filtering for warmup data, which we don't need to do anymore after this improvement.