#3315 - upgrade prometheus client java to 1.1.0 #3325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Nov 17, 2023
...ometheus-metrics/src/main/scala/sttp/tapir/server/metrics/prometheus/PrometheusMetrics.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Nov 17, 2023
...ometheus-metrics/src/main/scala/sttp/tapir/server/metrics/prometheus/PrometheusMetrics.scala
Outdated
Show resolved
Hide resolved
adamw
reviewed
Nov 17, 2023
...ometheus-metrics/src/main/scala/sttp/tapir/server/metrics/prometheus/PrometheusMetrics.scala
Outdated
Show resolved
Hide resolved
|
Thanks! This looks good :) I left a couple of minor comments |
gastonschabas
commented
Nov 17, 2023
...ometheus-metrics/src/main/scala/sttp/tapir/server/metrics/prometheus/PrometheusMetrics.scala
Outdated
Show resolved
Hide resolved
...ometheus-metrics/src/main/scala/sttp/tapir/server/metrics/prometheus/PrometheusMetrics.scala
Outdated
Show resolved
Hide resolved
...ometheus-metrics/src/main/scala/sttp/tapir/server/metrics/prometheus/PrometheusMetrics.scala
Outdated
Show resolved
Hide resolved
|
It seems that compiling the docs has failed - probably some updates are needed there as well |
Yeah. I saw the pipelines failing. I'm running locally to see how I can fix it |
… packages due to the upgrade of the java client
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to use the bridge provided by prometheus to not have the need of upgrading the old client produced a bug reported in #3315.
I upgraded the prometheus java client following the instructions to refactor the instrumentation code to the version 1.1.0 which is the latest one today and was released 5 days ago.
I also modified the assertions of the
PrometheusMetricsTestsuite. Instead of just validating that there is an exact string contained in the metrics generated, I changed for regex. This is because the test started to failed. When I checked what was the issue, the problem was that the labels were in different order. The regex applied will validate that the metric has a name and some labels with values no matter the order they have. The same happens with the ones that were validating that the comments such as# HELP tapir_request_total Total HTTP requests. It seems that with the new client if there is no value for that metric, the text will not be showedCloses #3315