-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Implement serverWithStop in all test interpreters #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
force-pushed
the
netty-tests-with-stop
branch
from
November 8, 2023 20:27
74ac308
to
03d72e5
Compare
kciesielski
changed the title
[WIP] Refactor serverWithStop in test interpreters
[WIP] Implement serverWithStop in all test interpreters
Nov 8, 2023
kciesielski
changed the title
[WIP] Implement serverWithStop in all test interpreters
Implement serverWithStop in all test interpreters
Nov 9, 2023
kciesielski
changed the title
Implement serverWithStop in all test interpreters
[tests] Implement serverWithStop in all test interpreters
Nov 9, 2023
adamw
reviewed
Nov 9, 2023
server/tests/src/main/scala/sttp/tapir/server/tests/TestServerInterpreter.scala
Outdated
Show resolved
Hide resolved
adamw
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! :) one left-over type alias, I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #3294
Implements
serverWithStop
for all test interpreters, so that any server test can now be run with graceful shutdown enabled, as well as shutdown hook (called KillSwitch) available as a test parameter usingtestServerLogicWithStop
.Example:
Some servers don't seem to support graceful shutdown out of the box, namely
VertX
,zio-http 1.x
,http4s (Blaze)
.