Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RejectContext to RejectHandler. #3285

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Grryum
Copy link
Contributor

@Grryum Grryum commented Oct 30, 2023

Motivation

Sometimes, in order to form the body of the response in the case of 404 Not Found, it is necessary to use data from the request (for example headers: requestId, cookie etc). It is impossible to do this without implementing your custom RejectInterceptor.

Implementing custom reject interceptor and prepending it to CustomiseInterceptors brake standard interceptor order and may lead to unwanted behavior.

@Grryum
Copy link
Contributor Author

Grryum commented Oct 31, 2023

@adamw could you please take a look? I tried to align logic in case of reject interceptor handlers to other default interceptors handlers

@Grryum Grryum changed the title Added RejectContext to RejectHandler. Add RejectContext to RejectHandler. Oct 31, 2023
@kciesielski kciesielski merged commit 2c26873 into softwaremill:master Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants