Feature: Add iron's RefinedTypeOps support #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbergeron
force-pushed
the
tapir-iron-refined-type-support
branch
from
d0820af to
cfcf325
Compare
adamw
reviewed
Oct 16, 2023
| @@ -18,6 +18,11 @@ import io.github.iltotore.iron.constraint.all.* | |||
| import sttp.tapir.Validator | |||
| import sttp.tapir.ValidationError | |||
|
|
|||
| // Opaque aliases can't be included into class bodies | |||
| type RefinedIntConstraint = Interval.ClosedOpen[0, 10] | |||
| opaque type RefinedInt <: Int = Int :| RefinedIntConstraint | |||
There was a problem hiding this comment.
shouldn't the opaque type alias be defined in a separate file, so that it's alias is not visible inside this file (and hence inside the test)? Otherwise we might be testing behaviour similar to a normal type alias?
There was a problem hiding this comment.
Right, I moved the opaque definition to its own file.
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Iron library, a common pattern is to hide the constrained type behind an opaque alias, to disallow similarly constrained types (The same result can be obtained using
DescribedAs, but I prefer not messing description with identity).Once the alias is opaque, it is not possible anymore to derive instances with the
Value :| Predicatetype pattern.This PR provides instances relying on the given
RefinedTypeOps.Mirror[T]instance that is provided byRefinedTypeOpsImpl.I wonder if the provided tests are enough or if there is corner cases I need to be aware of.