Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry metrics example #3213

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Add OpenTelemetry metrics example #3213

merged 7 commits into from
Oct 3, 2023

Conversation

rucek
Copy link
Contributor

@rucek rucek commented Sep 28, 2023

Adds a complete example of setting up OpenTelemetry metrics, using a gRPC exporter which sends the default metrics to an external collector.

@rucek rucek requested review from adamw and kciesielski September 28, 2023 09:13
@adamw
Copy link
Member

adamw commented Sep 28, 2023

cc @softberries, what do you think? :)

Copy link
Member

@kciesielski kciesielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using Pekko instead of Akka? Or maybe even Netty-Future server? I think the latter is what we'd like to promote as our preferred Future backend, the example would also be a bit simpler.

@rucek
Copy link
Contributor Author

rucek commented Sep 28, 2023

How about using Pekko instead of Akka? Or maybe even Netty-Future server? I think the latter is what we'd like to promote as our preferred Future backend, the example would also be a bit simpler.

If this is the preferred one, I'd say why not. Then we can perhaps also update the other examples (of which this one is a copy) for consistency - WDYT?

@kciesielski
Copy link
Member

That could be useful, in a separate PR. I guess we still want some Akka example(s) to show just how to use the Akka backend, but other examples could be rewritten to Pekko, wdyt @adamw?

@adamw
Copy link
Member

adamw commented Sep 28, 2023

That could be useful, in a separate PR. I guess we still want some Akka example(s) to show just how to use the Akka backend, but other examples could be rewritten to Pekko, wdyt @adamw?

Makes sense, either Pekko or maybe Netty-Future? Of course we should keep Akka for the example which showcase integration with Akka, but otherwise keeping the "noise" to a minimum is best to showcase a feature

@rucek rucek requested a review from kciesielski October 2, 2023 12:04
@rucek rucek requested a review from adamw October 3, 2023 09:23
@adamw adamw merged commit 3d981a7 into master Oct 3, 2023
13 checks passed
@mergify mergify bot deleted the otel-example branch October 3, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants