-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTelemetry metrics example #3213
Conversation
cc @softberries, what do you think? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using Pekko instead of Akka? Or maybe even Netty-Future server? I think the latter is what we'd like to promote as our preferred Future backend, the example would also be a bit simpler.
If this is the preferred one, I'd say why not. Then we can perhaps also update the other examples (of which this one is a copy) for consistency - WDYT? |
That could be useful, in a separate PR. I guess we still want some Akka example(s) to show just how to use the Akka backend, but other examples could be rewritten to Pekko, wdyt @adamw? |
examples/src/main/scala/sttp/tapir/examples/observability/OpenTelemetryMetricsExample.scala
Show resolved
Hide resolved
Makes sense, either Pekko or maybe Netty-Future? Of course we should keep Akka for the example which showcase integration with Akka, but otherwise keeping the "noise" to a minimum is best to showcase a feature |
Adds a complete example of setting up OpenTelemetry metrics, using a gRPC exporter which sends the default metrics to an external collector.