Refactor reused enum-based macros #3208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3206
This part moves
isScalaEnum[T]
fromjson-pickler
tocore
internals for potential reuse. It also extracts the part that checks for object/enum children.By the way, I noticed that the implementation I had in
json-pickler
wasn't recursive like the implementation used inValidationMacros
. Now it's the common one used, with a parameter that tells whether to fail if an unexpected child flag is found.I could not think of any example to represent a nested case to test the actual recursion. Any ideas? :)