-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pickler derivation #3134
Merged
Merged
Pickler derivation #3134
Changes from 42 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
153acb0
Scaffolding for pickler derivation
kciesielski 4a99a1f
Implement writer logic (without customizations)
kciesielski ed78b0b
Support readers
kciesielski 899ecf5
Respect schema's encodedName in writers
kciesielski 1306ae2
Derive schema for product inside pickler derivation
kciesielski c549f65
Support encodedName in readers
kciesielski f49baea
Fix writers for oneOfUsingField
kciesielski 598a68a
Implement support for Readers for oneOfUsingField
kciesielski ebc489a
Initial support for enumerations
kciesielski 6f94aff
Handle case objects consistently using discriminators
kciesielski d85c66d
Support enums
kciesielski 84fc706
Implement support for @default
kciesielski 313d5a6
Support Option[T]
kciesielski ebf4f70
Support for iterables
kciesielski f851300
Support Either (the uPickle way)
kciesielski 9167e41
Support Map (excluding keys as value classes)
kciesielski 48eed1e
Support Arrays
kciesielski 435ba96
Use Scala 3 convention for wildcard imports
kciesielski 0365da1
Support value classes
kciesielski 9fc5c34
Move code to a dedicated module
kciesielski 8a30e98
Rename scala-3 to scala
kciesielski b834153
Fix using default Pickler + some cleanup
kciesielski dc89ce8
Cleanup in tests
kciesielski 0ba847c
More refactoring
kciesielski b7891dd
Migrate SchemaGenericAutoTest
kciesielski 6b677df
Adjust handling of validateEach
kciesielski 16d89f1
Add a comment about missing support for `@description`
kciesielski cc4be0d
Add API for jsonBody
kciesielski f86ab4a
Ensure support for `derives`
kciesielski 1c57a0a
Build for ScalaJS
kciesielski 2bc2dfd
Remove debug code
kciesielski 9893845
Tune error message
kciesielski 1b5b949
Put all into a `pickler` package
kciesielski 2b9fbef
Improve errors for missing picklers
kciesielski 5a4731c
Report Pickler summon failure for the last actual failed case
kciesielski 34a7b03
Code comments and more package private restrictions
kciesielski 3b4db81
More dependencies for examples3
kciesielski 4492a98
Restore test for deriving schema for list
kciesielski 1994cfa
Documentation
kciesielski c82fbca
Don't compile Scala 3 snippets
kciesielski d42ff75
Test for enums with fields and default derivation method
kciesielski ae6b7bf
Improve usage of SubtypeDiscriminator
kciesielski 70bce41
Fix Scaladoc formatting
kciesielski f5879e7
Handle sealed hierarchies diguised as enums
kciesielski 048aaec
Revert "Documentation"
kciesielski 9e2d824
Recommit docs without autoformatting
kciesielski bfff425
Add support for java.math.BigDecimal and BigInteger
kciesielski f65fe75
Documentation improvements
adamw 00ac6c2
Formatting
adamw 989b080
Docs
adamw dc8f5b5
Docs
adamw b9ddf2a
Remove unused parameter
adamw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
OrganizeImports { | ||
groupedImports = Merge | ||
removeUnused = false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we support js as well? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed
js
support and left it for later due to some missing types. However, now it seems to work, so I'll bring it back and we'll see on the CI.