Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pekko grpc support #3124

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Conversation

pjfanning
Copy link
Contributor

  • add pekko example

build.sbt Show resolved Hide resolved
@adamw
Copy link
Member

adamw commented Aug 22, 2023

Now it seems there are some compile problems (in the scala 3 + jvm version)

@pjfanning
Copy link
Contributor Author

pjfanning commented Aug 23, 2023

Now it seems there are some compile problems (in the scala 3 + jvm version)

I've changed the pekko-grpc example to not support Scala 3 - pbDirectProtobuf is not ready for scala 3

@adamw
Copy link
Member

adamw commented Aug 29, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

rebase

✅ Branch has been successfully rebased

@adamw
Copy link
Member

adamw commented Aug 30, 2023

Somehow this breaks the JS builds ... maybe the sbt plugin updates some guava components?

@pjfanning
Copy link
Contributor Author

@adamw the guava dependency seems to come from io.grpc:grpc-core:1.48.1. akka-grpc also relies on io.grpc:grpc-core.

So I am not sure why this build issue only seems to affect pekko-grpc.

@adamw
Copy link
Member

adamw commented Sep 20, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 20, 2023

rebase

✅ Branch has been successfully rebased

@pjfanning
Copy link
Contributor Author

Would it make sense to update the build scripting to exclude pekko-grpc from the javascript build?

@adamw
Copy link
Member

adamw commented Sep 20, 2023

Unfortunately the entier build is failing, not only the grpc modules. The exception is from the catsJS2_12 module, completely unrelated to grpc

@kciesielski
Copy link
Member

I added a workaround for the guava issue, also proposed a fix in pekko-grpc. Let's see if it helps :)

@kciesielski kciesielski merged commit 0fe3c05 into softwaremill:master Sep 27, 2023
10 checks passed
@pjfanning pjfanning deleted the pekko-grpc branch September 27, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants