-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pekko grpc support #3124
add pekko grpc support #3124
Conversation
pjfanning
commented
Aug 20, 2023
- add pekko example
Now it seems there are some compile problems (in the scala 3 + jvm version) |
I've changed the pekko-grpc example to not support Scala 3 - pbDirectProtobuf is not ready for scala 3 |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Somehow this breaks the JS builds ... maybe the sbt plugin updates some guava components? |
@adamw the guava dependency seems to come from io.grpc:grpc-core:1.48.1. akka-grpc also relies on io.grpc:grpc-core. So I am not sure why this build issue only seems to affect pekko-grpc. |
@Mergifyio rebase |
pekko example pekko grpc release
✅ Branch has been successfully rebased |
Would it make sense to update the build scripting to exclude pekko-grpc from the javascript build? |
Unfortunately the entier build is failing, not only the grpc modules. The exception is from the |
I added a workaround for the guava issue, also proposed a fix in pekko-grpc. Let's see if it helps :) |