Use uploadDir path from VertxServerSettings instead of internal Vertx default value + fix deprecations & unused imports #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grryum
changed the title
Grryum
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve codebase by utilizing the uploadDir path from the VertxServerSettings configuration instead of relying on the internal Vertx default value.
Before this fix there was an issue where Vertx created unnecessary upload directories with default name (
file-uploads) for every request, even without endpoints with file input type:https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java#L234
The main cause is that BodyHandler by default is created with ability to handle file uploads and default upload dir:
https://github.com/vert-x3/vertx-web/blob/master/vertx-web/src/main/java/io/vertx/ext/web/handler/impl/BodyHandlerImpl.java#L60
https://github.com/softwaremill/tapir/blob/master/server/vertx-server/src/main/scala/sttp/tapir/server/vertx/handlers/package.scala#L12