Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Play Framework and JsonPlay to support Scala 3 #3089

Merged
merged 18 commits into from
Oct 26, 2023

Conversation

KapStorm
Copy link
Contributor

@KapStorm KapStorm commented Aug 1, 2023

Update Play Framework and PlayJson to support Scala 3 in tapir-play-server and tapir-json-play projects

Play Framework 2.9 doesn't support Scala 2.12, so tapir-play-server won't either


edit (by @kciesielski)

This PR has been updated to Play 3.0.

@kciesielski
Copy link
Member

I am not sure if we can afford removing support for Scala 2.12 just yet. I would wait for the final release of Play 2.9 and re-check our download stats for play-server_2.12 then.
Current stats (data from June, maybe Sonatype needs more time to generate data from July):

Scala version tapir version unique IPs Downloads
2.13 1.5.4 40 120
2.12 1.5.5 22.5 35
2.13 1.6.0 25 35
2.12 1.6.0 16 20

@adamw
Copy link
Member

adamw commented Aug 16, 2023

I think we should follow the latest Play release, once it drops 2.12, we update Play & drop 2.12 as well. So let's wait for the final non-RC version :)

project/Versions.scala Outdated Show resolved Hide resolved
@gaeljw
Copy link
Contributor

gaeljw commented Oct 26, 2023

From what I see, this PR targets Play 3.0, but shouldn't we first target Play 2.9 (released yesterday in the repos, no official announcement yet)?

Play 3.0 brings the change from Akka to Pekko. I'm not entirely sure how to go with the change in Tapir. Should Tapir support both Play 2.x + Akka & Play 3.x + Pekko? 🤔

@kciesielski
Copy link
Member

kciesielski commented Oct 26, 2023

@gaeljw We'll bump the play server to 3.0, and, if there's demand for 2.9, we'll probably create a separate tapir-play29 module. Akka 2.6 is no longer supported since September, so it's highly recommended to switch to Play 3.0 anyway.

@adamw adamw merged commit a4a7fac into softwaremill:master Oct 26, 2023
10 checks passed
@adamw
Copy link
Member

adamw commented Oct 26, 2023

Thanks for your work on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants