fix enum serdes generated from codegen #3085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughsimpson
changed the title
…en at $enumField" error for codegen enums
hughsimpson
force-pushed
the
fix_enum_codec
branch
from
d5513f9 to
b477855
Compare
kciesielski
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst it compiled, actually using the generated tapir code for enumeratum failed at runtime with
Invalid value for: body (JSON decoding to CNil should never happen at 'myEnumField')I have actually tested that the generated code works this time around
Additionally, it looks like enums should have an explicit type specified (cf https://swagger.io/docs/specification/data-models/enums/) - I've updated the decoder to require that the type is
string(we don't support any other types at present) and shuffled the decoder ordering so that we don't decode an enum to aOpenapiSchemaStringiftype: stringis present