Use operation id for endpoint name generation in codegen #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense - though there are some tests failing in |
|
Mea culpa - sorry about that, not sure how I missed those failing tests. Pushed fix now. |
|
Thanks! |
|
You're more than welcome. I've been using Tapir since I saw your talk at ScalaWorld in... 2019? Very keen on the codegen stuff, so might have room to help more if the wind blows from the right direction |
Great to hear :) The codegen module definitely needs a lot of work (there are quite a lot of issues with the codegen label, for example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making #3059 it occurred to me that I wouldn't even have had the issue if tapir was using operationId to generate the endpoint name...