[bugfix] Return raw ZIO response body where applicable #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kciesielski
force-pushed
the
bugfix/3034-zio-http-raw-body
branch
from
d76d77f to
3c0a109
Compare
adamw
reviewed
Jul 20, 2023
| def contentLength: Option[Long] | ||
| } | ||
|
|
||
| private[ziohttp] case class ZioStreamHttpResponseBody(stream: ZStream[Any, Throwable, Byte], val contentLength: Option[Long]) |
There was a problem hiding this comment.
[minor] is the val needed? it is a case class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3034
This PR changes handling of raw body types. Instead of always using a
ZStream, such responses are packed into aChunk[Byte]. This allows logging the response body byzio.http.internal.middlewares.RequestLogging.