[bugfix] Sending Accept-Charset causes 406 NotAcceptable response #3013
Conversation
| // mozilla says servers should ignore the Accept-Charset header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Charset | ||
| val hasAcceptCharset = ctx.request.header(HeaderNames.AcceptCharset).nonEmpty | ||
|
|
||
| if (hasMatchingRepresentation || hasAcceptCharset) endpointHandler.onDecodeSuccess(ctx) |
There was a problem hiding this comment.
I don't think this fix ignores the accept-charset header, it seems to bypass content negotiation when this header is present?
There was a problem hiding this comment.
You're right. It checks to see if we have that header and if we have, we move on. I didn't have any other idea about it, maybe a hint for better solution?
There was a problem hiding this comment.
sorry, I have no idea, I would have to go and try to fix the issue myself ;)
There was a problem hiding this comment.
ok, so I will think and try another solution ;)
|
Sorry but it most probably still is the wrong solution. You are filtering out accept-charset, but in a different place. The first thing that's lacking in the PR is a test, that would demonstrate the bug. Let's start with that, probably in |
…on in NotAcceptableInterceptor
PanHNE
force-pushed
the
2994_Sending_Accept-Charset_causes_406_NotAcceptable_response
branch
from
1fa020a to
ec944d9
Compare
mergify
bot
deleted the
2994_Sending_Accept-Charset_causes_406_NotAcceptable_response
branch
No description provided.