Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed zio metric type for active requests from Count to Gauge. #2990

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

Grryum
Copy link
Contributor

@Grryum Grryum commented Jun 24, 2023

A counter is not a good way to represent requests active metrics, as many platforms handle counters differently than a gauge. It seems like keeping track of the active requests should be represented as a gauge.

According to:

Prometheus docs: https://prometheus.io/docs/concepts/metric_types/#counter

Do not use a counter to expose a value that can decrease. For example, do not use a counter for the number of currently running processes; instead use a gauge.

Datadog docs: https://docs.datadoghq.com/metrics/types/?tab=count

The COUNT metric submission type represents the total number of event occurrences in one time interval. A COUNT can be used to track the total number of connections made to a database or the total number of requests to an endpoint.

@kciesielski kciesielski self-assigned this Jun 26, 2023
@kciesielski
Copy link
Member

Thanks a lot, @Grryum!

@kciesielski kciesielski merged commit 86e1587 into softwaremill:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants