Feature/serverless zio #2975
Merged
Feature/serverless zio #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kciesielski could you take a look maybe? :) |
kciesielski
approved these changes
Jun 23, 2023
build.sbt
Outdated
| if (!samReady) { | ||
| sam.destroy() | ||
| val exit = sam.exitValue() | ||
| log.error(s"failed to start sam local within 60 seconds (exit code: $exit") |
There was a problem hiding this comment.
Suggested change
| log.error(s"failed to start sam local within 60 seconds (exit code: $exit") | |
| log.error(s"failed to start sam local within 60 seconds (exit code: $exit)") |
build.sbt
Outdated
| Tests.Cleanup(() => { | ||
| sam.destroy() | ||
| val exit = sam.exitValue() | ||
| log.info(s"stopped sam local (exit code: $exit") |
There was a problem hiding this comment.
Suggested change
| log.info(s"stopped sam local (exit code: $exit") | |
| log.info(s"stopped sam local (exit code: $exit)") |
| @@ -9,7 +9,7 @@ import sttp.tapir.server.interceptor.RequestResult | |||
| import sttp.tapir.server.interceptor.reject.RejectInterceptor | |||
| import sttp.tapir.server.interpreter.{BodyListener, FilterServerEndpoints, ServerInterpreter} | |||
|
|
|||
| private[lambda] abstract class AwsServerInterpreter[F[_]: MonadError] { | |||
| private[aws] abstract class AwsServerInterpreter[F[_]: MonadError] { | |||
There was a problem hiding this comment.
question: This change isn't needed, right? Or maybe I'm missing something?
There was a problem hiding this comment.
That is required, because sttp.tapir.serverless.aws.ziolambda.AwsZioServerInterpreter depends on sttp.tapir.serverless.aws.lambda.AwsServerInterpreter and for these two the closest common package is sttp.tapir.serverless.aws. That is why it should be private to [aws] to make the code compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2931