Added ZIO based server for netty #2574
Conversation
build.sbt
Outdated
| .settings( | ||
| name := "tapir-netty-server-zio", | ||
| libraryDependencies ++= Seq( | ||
| "io.netty" % "netty-all" % "4.1.82.Final", |
There was a problem hiding this comment.
let's extract netty's version to a constant in the build so that it's not repeated
build.sbt
Outdated
| "dev.zio" %% "zio-interop-cats" % Versions.zioInteropCats, | ||
| ) ++ loggerDependencies, | ||
| // needed because of https://github.com/coursier/coursier/issues/2016 | ||
| useCoursier := false |
There was a problem hiding this comment.
maybe some common netty-settings to avoid duplication?
There was a problem hiding this comment.
I think that not much things can be move to common as most setting is different between backends
There was a problem hiding this comment.
even if it's 2 settings let's factor them out so that we don't repeat the comments etc.
| case class NettyZioServer[R, SA <: SocketAddress](routes: Vector[Route[RIO[R, *]]], options: NettyZioServerOptions[R, SA])(implicit | ||
| runtime: Runtime[R] | ||
| ) { | ||
| def addEndpoint(se: ServerEndpoint[Any, RIO[R, *]]): NettyZioServer[R, SA] = addEndpoints(List(se)) |
There was a problem hiding this comment.
I think here we should use ZServerEndpoint from sttp.tapir.ztapir
| import sttp.tapir.server.netty.internal.FutureUtil | ||
| import zio.{RIO, ZIO} | ||
|
|
||
| object ZioUtil { |
There was a problem hiding this comment.
and this function is available from the parent project?
There was a problem hiding this comment.
I am not sure which one ? FutureUtil is public
There was a problem hiding this comment.
Ah it's a conversion to RIO, ok. Does it need to be public? It looks like an impl detail
There was a problem hiding this comment.
already moved to private in zio
|
Looks good - docs are missing :) |
|
Seventh task in #499 |
|
You'll also probably need to implement this: #2579 in the ZIO variant ( |
|
closes in favor of #2602 |
No description provided.