SttpMockServerClient drops null values #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Jun 6, 2022
| .thenError(sampleErrorOut, statusCode = StatusCode.BadRequest) | ||
|
|
||
| expectations should have size 1 | ||
| println(expectations.head.httpRequest.path) |
adamw
reviewed
Jun 6, 2022
| } | ||
|
|
||
| it should "match json body with drop null" in { | ||
| import TapirJsonCirceWithDropNull._ |
There was a problem hiding this comment.
I wanted to make it explicit for these two cases that they are using different configurations related to this drop option.
There was a problem hiding this comment.
but are they? are you using the jsonBody method defined by these objects anywhere?
adamw
reviewed
Jun 6, 2022
| @@ -537,6 +544,252 @@ class MockServerSpec extends AnyFlatSpec with Matchers { | |||
| ) | |||
| } | |||
|
|
|||
| it should "match json body without drop null" in { | |||
There was a problem hiding this comment.
these tests are enormous. Is there a way to somehow deduplicate them, so that it would be visible what's the difference in the null handling, and where the nulls are in the first palce (or not)?
|
Can you rebase? The examples are now moved to dedicated directories |
mkrzemien
force-pushed
the
2128-sttpmockserverclient-drops-null-values
branch
2 times, most recently
from
eadaac4 to
71b154f
Compare
adamw
approved these changes
Jun 7, 2022
mkrzemien
force-pushed
the
2128-sttpmockserverclient-drops-null-values
branch
from
84c5bbc to
baae091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2128