Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require value class parameters list to not be empty #1774

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

kubinio123
Copy link
Contributor

@kubinio123 kubinio123 commented Jan 20, 2022

I don't know if there is something better we can do for the reported case for scala2 (we could probably implement some macro to do the check in compile time but is it worth the effort)? I added the test in scala2 sources since for scala3 it won't compile although not mentioning the Num class specifically in the message.

@kubinio123 kubinio123 requested a review from adamw January 20, 2022 15:45
@adamw adamw merged commit 4799a8b into master Jan 20, 2022
@adamw
Copy link
Member

adamw commented Jan 20, 2022

Thanks, yeah I guess that's as far as we can get with automatic derivation.

@mergify mergify bot deleted the require-value-class-parameters branch January 20, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] runtime failure on start-up with ArrayIndexOutOfBoundsException
2 participants