Gzip file handling #1542
Merged
Gzip file handling #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
self-assigned this
adamw
reviewed
Oct 22, 2021
| @@ -223,9 +242,13 @@ trait TapirStaticContentEndpoints { | |||
| */ | |||
| def resourceGetServerEndpoint[F[_]](prefix: EndpointInput[Unit])( | |||
| classLoader: ClassLoader, | |||
| resourcePath: String | |||
| resourcePath: String, | |||
| preGzipped: Boolean = false | |||
There was a problem hiding this comment.
I think we need to change the name - I wouldn't guess what the preGzipped flag does ;) useGzippedIfAvailable?
Also, shouldn't we add this to the other variants of the methods?
adamw
reviewed
Oct 22, 2021
| case Some(v) => | ||
| val option = v.split(",").headOption | ||
| val right = | ||
| if (option.exists(_.equals("gzip"))) Right(option) |
There was a problem hiding this comment.
I think we're filtering too early. Let's leave the acceptEncodingHeader parse whatever encodings are given (after all, it's an acceptEncodingHeader not gzipEncodingHeader) and filter later
adamw
reviewed
Oct 22, 2021
| serveRoute(resourceGetServerEndpoint[F](emptyInput)(loader, "test/r3.txt", preGzipped = true)) | ||
| .use { port => | ||
| emptyRequest | ||
| .get(uri"http://localhost:$port/test/r3.txt") |
There was a problem hiding this comment.
this should be r3 without .txt, or the gzipped version should be r3.txt.gz?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1434