Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authorizationUrl optional #1342

Merged
merged 2 commits into from
Jun 27, 2021

Conversation

dvgica
Copy link
Contributor

@dvgica dvgica commented Jun 26, 2021

Fixes #1336.

@adamw
Copy link
Member

adamw commented Jun 26, 2021

Thanks! There seem to be some compile errors in the openapiDoc project, though

@dvgica
Copy link
Contributor Author

dvgica commented Jun 26, 2021 via email

@dvgica dvgica force-pushed the fix-reqd-authorization-url branch from 71d133c to 2f5da55 Compare June 27, 2021 02:17
@dvgica
Copy link
Contributor Author

dvgica commented Jun 27, 2021

@adamw the whole project now compiles, including tests. I'm having a bit of trouble actually running the tests to completion before either SBT or my whole Linux VM dies, but I'll keep trying.

@adamw
Copy link
Member

adamw commented Jun 27, 2021

@dvgica yeah I don't think you can do that, there's a problem with running all of the JS tests (they run in Chrome, and the Chrome instances aren't properly closed - see scala-js/scala-js#4317 ). A work-around is to run only jvm tests (using testJVM), or individual JS tests. See also the readme :)

@adamw adamw merged commit 55b5776 into softwaremill:master Jun 27, 2021
@adamw
Copy link
Member

adamw commented Jun 27, 2021

Thanks!

@dvgica
Copy link
Contributor Author

dvgica commented Jun 28, 2021

Thanks for the quick merge! I'll read the README closer next time.... 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] authorizationUrl in OAuthFlow should be optional
2 participants