Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1156: remove the I/E/O type parameters from ServerEndpoint #1157

Closed
wants to merge 5 commits into from

Conversation

adamw
Copy link
Member

@adamw adamw commented Apr 10, 2021

No description provided.

@@ -271,14 +275,14 @@ trait EndpointServerLogicOps[I, E, O, -R] { outer: Endpoint[I, E, O, R] =>
* returned [[ServerEndpoint]] value (except for endpoint meta-data). To provide the logic in parts, see
* [[serverLogicPart]] and [[serverLogicForCurrent]].
*/
def serverLogic[F[_]](f: I => F[Either[E, O]]): ServerEndpoint[I, E, O, R, F] = ServerEndpoint(this, _ => f)
def serverLogic[F[_]](f: I => F[Either[E, O]]): ServerEndpoint[R, F] = ServerEndpoint(this, _ => f)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed previously in #1156, can this method return ServerEndpoint.Aux[I, E, O, R, F]?

@adamw
Copy link
Member Author

adamw commented Oct 24, 2021

@catostrophe please see #1167 (comment) as I think you are using ServerEndpoint in some more advanced way, so this might impact you as well

@catostrophe
Copy link

Are you going to merge this one into 0.19? I would like to test it directly with our code, but I need a green branch that is compatible with the latest release. So that I could build it locally and check

@adamw
Copy link
Member Author

adamw commented Oct 24, 2021

@catostrophe I think I'll rather close this without merging, as returning Aux everywhere would only complicate things without a clear benefit. Though I'm not 100% decided yet, it would also be nice to represent lists of server endpoints in a nicer way. But anyway, the SecureEndpoint changes (as described in the link above) would influence the changes here.

@adamw
Copy link
Member Author

adamw commented Nov 2, 2021

Superseded by fa7e5a8 as part of #1167

@adamw adamw closed this Nov 2, 2021
@mergify mergify bot deleted the simpler-server-endpoint branch November 2, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants