-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1156: remove the I/E/O type parameters from ServerEndpoint #1157
Conversation
@@ -271,14 +275,14 @@ trait EndpointServerLogicOps[I, E, O, -R] { outer: Endpoint[I, E, O, R] => | |||
* returned [[ServerEndpoint]] value (except for endpoint meta-data). To provide the logic in parts, see | |||
* [[serverLogicPart]] and [[serverLogicForCurrent]]. | |||
*/ | |||
def serverLogic[F[_]](f: I => F[Either[E, O]]): ServerEndpoint[I, E, O, R, F] = ServerEndpoint(this, _ => f) | |||
def serverLogic[F[_]](f: I => F[Either[E, O]]): ServerEndpoint[R, F] = ServerEndpoint(this, _ => f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed previously in #1156, can this method return ServerEndpoint.Aux[I, E, O, R, F]
?
@catostrophe please see #1167 (comment) as I think you are using |
Are you going to merge this one into 0.19? I would like to test it directly with our code, but I need a green branch that is compatible with the latest release. So that I could build it locally and check |
@catostrophe I think I'll rather close this without merging, as returning |
No description provided.