Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml test cleanup #1101

Merged
merged 3 commits into from
Mar 25, 2021
Merged

Yaml test cleanup #1101

merged 3 commits into from
Mar 25, 2021

Conversation

kubinio123
Copy link
Contributor

No description provided.

@kubinio123 kubinio123 requested a review from adamw March 24, 2021 14:18

val actualYamlNoIndent = noIndentation(actualYaml)
actualYamlNoIndent shouldBe expectedYaml
}
}

case class F1(data: List[F1])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all of these classes used by the remaining tests?

If so, I'd move them inside an object VerifyYamlTest and import VerifyYamlTest._ here. If some are shared, it's fine to copy them (since these are tests), so that the tests are independent. This is already partially done for coproduct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, adjusted

@kubinio123 kubinio123 requested a review from adamw March 25, 2021 09:11
@adamw adamw merged commit c7cbf0c into master Mar 25, 2021
@adamw
Copy link
Member

adamw commented Mar 25, 2021

Thank you!

@mergify mergify bot deleted the yaml-test-cleanup branch March 25, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants