correct circe encoder for OpenAPI #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
Feb 10, 2021
| @@ -75,7 +75,7 @@ trait TapirOpenAPICirceEncoders { | |||
| implicit val encoderInfo: Encoder[Info] = deriveEncoder[Info] | |||
| implicit val encoderContact: Encoder[Contact] = deriveEncoder[Contact] | |||
| implicit val encoderLicense: Encoder[License] = deriveEncoder[License] | |||
| implicit val encoderOpenAPI: Encoder[OpenAPI] = deriveEncoder[OpenAPI] | |||
| implicit val encoderOpenAPI: Encoder[OpenAPI] = deriveEncoder[OpenAPI].mapJsonObject(json => json.filter{ case (_, v) => !v.isNull}.mapValues(_.deepDropNullValues)) | |||
There was a problem hiding this comment.
do we need the filter - isn't deepDropNullValues enough?
There was a problem hiding this comment.
yep, without that filter, only nested nulls were dropped but the ones within first braces were not
There was a problem hiding this comment.
ok, it can be simplified to deriveEncoder[OpenAPI].mapJson(json => json.deepDropNullValues), i've made correction
adamw
reviewed
Feb 10, 2021
doc/docs/openapi.md
Outdated
| import sttp.tapir.openapi.circe.yaml._ | ||
|
|
||
| println(docs.toYaml) | ||
| println(docs.asJson) |
There was a problem hiding this comment.
.asJson only coverts to a Json object, this isn't yet serialised to a string, right?
There was a problem hiding this comment.
yes, but println() automatically convert it
There was a problem hiding this comment.
let's maybe add an explicit example how to serialise to a string (if I remember correctly, using Printer)
dkarwacki
force-pushed
the
open-api-to-json
branch
from
a31209f to
7f536d3
Compare
dkarwacki
force-pushed
the
open-api-to-json
branch
from
7f536d3 to
4067bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.