Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Add original request to ServerRequest #893

Closed
wojciechUrbanski opened this issue Dec 21, 2020 · 1 comment
Closed

[Feature Request] Add original request to ServerRequest #893

wojciechUrbanski opened this issue Dec 21, 2020 · 1 comment

Comments

@wojciechUrbanski
Copy link
Contributor

Why
Sometimes, some business logic is dependant on specific implementation of Request for given server interpreter. Unfortunately, right now there is no easy way to extract original request representation and use it in further flow.

Proposition
ServerRequest might have an additional field, for example underlying: Any, which would represent original request. This way it could be extracted via extractFromRequest and used in business logic flow.
@adamw adamw closed this as completed in 1610eb2 Dec 22, 2020
adamw added a commit that referenced this issue Dec 22, 2020
@adamw
Merge pull request #895 from softwaremill/original-request
57a321f 
Fixes #893: access to the underlying request via ServerRequest
@adamw
Copy link
Member

adamw commented Dec 22, 2020

Added in 0.17.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamw @wojciechUrbanski