Fix broken links in docs #2180
Merged
Fix broken links in docs #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
reviewed
May 13, 2024
docs/backends/wrappers/custom.md
Outdated
| @@ -277,6 +277,7 @@ class MyCustomBackendHttpTest extends HttpTest[Future] { | |||
| } | |||
| ``` | |||
|
|
|||
| [//]: # (TO REVIEWER last update 6 years ago maybe we have sth newer) | |||
adamw
reviewed
May 13, 2024
docs/backends/http4s.md
Outdated
| @@ -35,6 +35,6 @@ Please note that: | |||
|
|
|||
| Instead, all custom timeout configuration should be done by creating a `org.http4s.client.Client[F]`, using e.g. `org.http4s.client.blaze.BlazeClientBuilder[F]` and passing it to the appropriate method of the `Http4sBackend` object. | |||
|
|
|||
| The backend supports streaming using fs2. For usage details, see the documentation on [streaming using fs2](fs2.md#streaming). | |||
| The backend supports streaming using fs2. For usage details, see the documentation on [streaming using fs2](https://sttp.softwaremill.com/en/latest/backends/fs2.html#streaming). | |||
There was a problem hiding this comment.
maybe let's just keep a link to fs2.md to avoid hard-coding links to our own docs
adamw
reviewed
May 13, 2024
docs/index.md
Outdated
| @@ -48,7 +48,10 @@ sttp is a family of Scala HTTP-related projects, and currently includes: | |||
| Third party projects: | |||
|
|
|||
| * [sttp-oauth2](https://github.com/ocadotechnology/sttp-oauth2): OAuth2 client library for Scala | |||
|
|
|||
| [//]: # (* TO REVIEWER repo archived by owner) | |||
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1419