Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1654 #1716

Merged
merged 5 commits into from
Feb 28, 2023
Merged

1654 #1716

merged 5 commits into from
Feb 28, 2023

Conversation

haoqin
Copy link

@haoqin haoqin commented Jan 30, 2023

Before submitting pull request:

  • Check if the project compiles by running sbt compile
  • Verify docs compilation by running sbt compileDocs
  • Check if tests pass by running sbt test
  • Format code by running sbt scalafmt

@haoqin
Copy link
Author

haoqin commented Jan 30, 2023

@adamw This is a draft PR to add accessors for zio 2, as mentioned in zio/zio#7601. Could you please take a look at it to see if the efforts are in the right direction and if there is anything missing? Thanks!

@adamw
Copy link
Member

adamw commented Jan 31, 2023

@haoqin thanks - I think this is promising :) would be great to revive some examples as well, to demonstrate (and verify) how this looks like in practice (both sending requests & stubbing)

@adamw
Copy link
Member

adamw commented Jan 31, 2023

This implements #1654

@haoqin
Copy link
Author

haoqin commented Feb 1, 2023

@haoqin thanks - I think this is promising :) would be great to revive some examples as well, to demonstrate (and verify) how this looks like in practice (both sending requests & stubbing)

@adamw Thanks for the feedback. Will work on the revision.

…ntZioBackend; added test cases; modified examples
@haoqin haoqin requested a review from adamw February 6, 2023 19:47
@haoqin haoqin marked this pull request as ready for review February 12, 2023 08:39
@adamw adamw merged commit 362019a into softwaremill:master Feb 28, 2023
@adamw
Copy link
Member

adamw commented Feb 28, 2023

Thanks for the PR and sorry for the delay. In the end I had to remove the stubbing code, as it was fragile and once again broken (during run-time). I also added some docs.

@haoqin
Copy link
Author

haoqin commented Mar 1, 2023

Thanks for the PR and sorry for the delay. In the end I had to remove the stubbing code, as it was fragile and once again broken (during run-time). I also added some docs.

Thanks a lot for your help @adamw. It's a pleasure to work with this project.

@haoqin haoqin deleted the 1654 branch March 1, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants