-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1654 #1716
1654 #1716
Conversation
@adamw This is a draft PR to add accessors for zio 2, as mentioned in zio/zio#7601. Could you please take a look at it to see if the efforts are in the right direction and if there is anything missing? Thanks! |
armeria-backend/zio/src/main/scala/sttp/client3/armeria/zio/zio.scala
Outdated
Show resolved
Hide resolved
armeria-backend/zio/src/main/scala/sttp/client3/armeria/zio/zio.scala
Outdated
Show resolved
Hide resolved
@haoqin thanks - I think this is promising :) would be great to revive some examples as well, to demonstrate (and verify) how this looks like in practice (both sending requests & stubbing) |
This implements #1654 |
…ntZioBackend; added test cases; modified examples
...-backend/zio/src/main/scala/sttp/client3/asynchttpclient/zio/AsyncHttpClientZioBackend.scala
Outdated
Show resolved
Hide resolved
armeria-backend/zio/src/main/scala/sttp/client3/armeria/zio/zio.scala
Outdated
Show resolved
Hide resolved
async-http-client-backend/zio/src/main/scala/sttp/client3/asynchttpclient/zio/package.scala
Outdated
Show resolved
Hide resolved
Thanks for the PR and sorry for the delay. In the end I had to remove the stubbing code, as it was fragile and once again broken (during run-time). I also added some docs. |
Thanks a lot for your help @adamw. It's a pleasure to work with this project. |
Before submitting pull request:
sbt compile
sbt compileDocs
sbt test
sbt scalafmt