Also catch fatal exceptions (e.g. InterruptedException) in MonadError…

….handleError
softwaremill · Nov 12, 2024 · 783ddc8 · 783ddc8
1 parent 97ee8dc
commit 783ddc8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.gitignore b/.gitignore
@@ -17,6 +17,7 @@ project/plugins/project/
 .worksheet
 
 .idea*
+.vscode
 
 .keys*
 
@@ -28,6 +29,6 @@ lowered.hnir
 # Bloop / Metals
 .bloop/
 .metals/
-project/metals.sbt
+metals.sbt
 
 .bsp
diff --git a/core/src/main/scala/sttp/monad/MonadError.scala b/core/src/main/scala/sttp/monad/MonadError.scala
@@ -23,10 +23,10 @@ trait MonadError[F[_]] {
   def error[T](t: Throwable): F[T]
   protected def handleWrappedError[T](rt: F[T])(h: PartialFunction[Throwable, F[T]]): F[T]
   def handleError[T](rt: => F[T])(h: PartialFunction[Throwable, F[T]]): F[T] = {
-    Try(rt) match {
-      case Success(v)                     => handleWrappedError(v)(h)
-      case Failure(e) if h.isDefinedAt(e) => h(e)
-      case Failure(e)                     => error(e)
+    try handleWrappedError(rt)(h)
+    catch {
+      case e: Throwable if h.isDefinedAt(e) => h(e)
+      case e: Throwable                     => error(e)
     }
   }