Fix providing annotations vs inherited annotations #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #525 introduced changes to
CollectAnnotations.fromDeclarations, causing incorrect creation of annotation list for class fields which override base trait fields:inheritedAnnsreturns an empty list, whileannsreturns a list containing both field annotations and inherited annotations.This problem slipped through tests, as we use a
Showderivation which prints strings without differentiating field/inherited annotations. The issue has been detected in Tapir schema derivation tests.This PR adjusts tests to include this distinction and fixes annotation extraction methods.