Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing naming to Foxai everywhere #60

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Changing naming to Foxai everywhere #60

merged 3 commits into from
Feb 14, 2023

Conversation

rpytel1
Copy link
Collaborator

@rpytel1 rpytel1 commented Feb 13, 2023 •
edited
Loading

Description

Please include a summary of the changes.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Test A
  • Test B

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

@rpytel1
Copy link
Collaborator Author

rpytel1 commented Feb 13, 2023

Tests are passing, basic_usage.ipynb is working well. Unfortuently, yolo_xai. ipynb needs some adjustments as the histogram doesn't work well.

@rpytel1 rpytel1 self-assigned this Feb 13, 2023
@rpytel1 rpytel1 added bug Something isn't working documentation Improvements or additions to documentation labels Feb 13, 2023
kamilrzechowski
kamilrzechowski approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@kamilrzechowski kamilrzechowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
@rpytel1 rpytel1 force-pushed the ref/fix_foxai_names branch 2 times, most recently from 6187131 to a813f9d Compare February 14, 2023 10:36
@rpytel1
Copy link
Collaborator Author

rpytel1 commented Feb 14, 2023

All tests and notebooks are working 🚀 We still have to change the name of the repository and pyproject.toml repository field.

kamilrzechowski
kamilrzechowski approved these changes Feb 14, 2023
View reviewed changes
Copy link
Collaborator

@kamilrzechowski kamilrzechowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/test_array_utils.py Outdated Show resolved Hide resolved
@rpytel1 rpytel1 force-pushed the ref/fix_foxai_names branch 4 times, most recently from fbe2228 to c0a5316 Compare February 14, 2023 11:34
@rpytel1 rpytel1 force-pushed the ref/fix_foxai_names branch from c0a5316 to 0594040 Compare February 14, 2023 11:40
@rpytel1 rpytel1 merged commit 5cbd591 into main Feb 14, 2023
@rpytel1 rpytel1 deleted the ref/fix_foxai_names branch February 14, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilrzechowski kamilrzechowski kamilrzechowski approved these changes

@adamwawrzynski adamwawrzynski Awaiting requested review from adamwawrzynski

@adamjankaczmarek adamjankaczmarek Awaiting requested review from adamjankaczmarek

Assignees

@rpytel1 rpytel1

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpytel1 @kamilrzechowski