Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Streamlit demo app and custom callback #43

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Remove Streamlit demo app and custom callback #43

merged 2 commits into from
Jan 16, 2023

Conversation

adamwawrzynski
Copy link
Collaborator

Description

This PR deletes Streamlit interactive demo app and custom callback.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • pre-commit

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

@adamwawrzynski adamwawrzynski self-assigned this Jan 12, 2023
@adamwawrzynski adamwawrzynski force-pushed the ref/remove_streamlit_demo branch from e8521f3 to 0ef50e1 Compare January 12, 2023 14:37
kamilrzechowski
kamilrzechowski approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@kamilrzechowski kamilrzechowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamwawrzynski adamwawrzynski marked this pull request as ready for review January 16, 2023 14:13
Bump patch version
33cd277 
Signed-off-by: Adam Wawrzyński <[email protected]>
@adamwawrzynski adamwawrzynski merged commit dae714e into main Jan 16, 2023
@adamwawrzynski adamwawrzynski deleted the ref/remove_streamlit_demo branch January 16, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilrzechowski kamilrzechowski kamilrzechowski approved these changes

@adamjankaczmarek adamjankaczmarek Awaiting requested review from adamjankaczmarek

@rpytel1 rpytel1 Awaiting requested review from rpytel1

Assignees

@adamwawrzynski adamwawrzynski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamwawrzynski @kamilrzechowski