WIP: fix: Removed limitation for length of message (1024) in function tran… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sformData. This limitation was causing partial logging for longer NDC messages. Since I do not have enough info for the various use cases, apart from NDC protocol, to decide on alternative value to 1024, I propose this limitation to be removed.
|
Can one of the admins verify this patch? |
|
This needs more discussion. Logging too much data is not good idea. |
kalinkrustev
changed the title
|
implemented via configuratoin: #48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed limitation for length of message (1024) in function transformData.
This limitation was causing partial logging for longer NDC messages. I do not have enough info for the various use cases of this module, apart from NDC protocol, to decide on alternative value to 1024.
I propose this limitation to be removed currently if this will not cause problems."
For reference on possible maximum length of NDC message, below you can find a note from Diebold's documentation on their implementation of Advance NDC: