Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Abi V0 files to starknet_py/abi/v0 #1299

Merged
merged 14 commits into from
Feb 23, 2024
Merged

Move Abi V0 files to starknet_py/abi/v0 #1299

merged 14 commits into from
Feb 23, 2024

Conversation

tkumor3
Copy link
Contributor

@tkumor3 tkumor3 commented Feb 21, 2024

Closes #1270

Introduced changes

  • This PR contains breaking changes

@tkumor3 tkumor3 self-assigned this Feb 21, 2024
@tkumor3 tkumor3 force-pushed the tomaszkumor/move_abi_v0 branch from 8e02aba to 67a3bff Compare February 21, 2024 12:04
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (012a081) 97.96% compared to head (ccc12eb) 97.96%.

Additional details and impacted files 
@@             Coverage Diff              @@
##           development    #1299   +/-   ##
============================================
  Coverage        97.96%   97.96%           
============================================
  Files               91       93    +2     
  Lines             4576     4580    +4     
============================================
+ Hits              4483     4487    +4     
  Misses              93       93
Files Coverage Δ
starknet_py/abi/v0/__init__.py 100.00% <ø> (ø)
starknet_py/abi/v0/model.py 100.00% <ø> (ø)
starknet_py/abi/v0/parser.py 97.64% <100.00%> (ø)
starknet_py/abi/v0/schemas.py 100.00% <100.00%> (ø)
starknet_py/abi/v0/shape.py 100.00% <ø> (ø)
starknet_py/abi/v1/__init__.py 100.00% <100.00%> (ø)
starknet_py/abi/v2/__init__.py 100.00% <100.00%> (ø)
starknet_py/abi/v2/parser.py 93.51% <100.00%> (ø)
starknet_py/contract.py 97.68% <100.00%> (ø)
starknet_py/net/client_models.py 99.76% <100.00%> (ø)
... and 5 more

ddoktorski
ddoktorski requested changes Feb 22, 2024
View reviewed changes
docs/guide/serialization.rst Outdated Show resolved Hide resolved
docs/api/abi.rst Show resolved Hide resolved
starknet_py/serialization/factory.py Outdated Show resolved Hide resolved
starknet_py/serialization/serialization_test.py Outdated Show resolved Hide resolved
docs/migration_guide.rst Outdated Show resolved Hide resolved
@tkumor3 tkumor3 requested a review from ddoktorski February 22, 2024 14:39
@ddoktorski ddoktorski changed the title Tomaszkumor/move abi v0 Move Abi V0 files to starknet_py/abi/v0 Feb 23, 2024
@ddoktorski ddoktorski merged commit 303212e into development Feb 23, 2024
16 checks passed
@ddoktorski ddoktorski deleted the tomaszkumor/move_abi_v0 branch February 23, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@THenry14 THenry14 Awaiting requested review from THenry14

Assignees

@tkumor3 tkumor3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Abi V0 files to starknet_py/abi/v0 directory
2 participants
@tkumor3 @ddoktorski