Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer readme #655

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Infer readme #655

merged 1 commit into from
Sep 13, 2023

Conversation

MrDenkoV
Copy link
Contributor

@MrDenkoV MrDenkoV commented Sep 8, 2023 •
edited
Loading

Fix #159

@MrDenkoV MrDenkoV requested a review from mkaput as a code owner September 8, 2023 12:45
mkaput
mkaput reviewed Sep 12, 2023
View reviewed changes
website/docs/reference/manifest.md Outdated Show resolved Hide resolved
website/docs/reference/manifest.md Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
scarb/src/core/manifest/toml_manifest.rs Outdated Show resolved Hide resolved
mkaput
mkaput approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@MrDenkoV MrDenkoV force-pushed the mrdenkov/infer_readme branch from 8e44109 to 9d738e3 Compare September 13, 2023 12:59
@MrDenkoV MrDenkoV added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit ba2c455 Sep 13, 2023
@MrDenkoV MrDenkoV deleted the mrdenkov/infer_readme branch September 13, 2023 13:37
mkaput added a commit that referenced this pull request Sep 20, 2023
@mkaput
Revert accidental breaking change introduced in #655
6e3e28c
@mkaput mkaput mentioned this pull request Sep 20, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 20, 2023
@mkaput
Revert accidental breaking change introduced in #655 (#694)
e8da195 
Changing type of a field (introduced in #655) is a semver breaking
change, and we can only do it in `scarb-metadata 2.0` release. This PR
reverts this type back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infer value of the readme field by looking for readme file when converting TomlManifest to Manifest
2 participants
@MrDenkoV @mkaput