feat: Support fontFeatureSettings
on web
#2463
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support is just a matter of making sure we pass through the value properly. Hopefully the property is supported on iOS soon, but for now, 2 (Android + web) out of 3 is better than 1 out of 3.
Test Plan
Ran change locally, worked fine. It's a pretty trivial change.
What's required for testing (prerequisites)?
An SVG with
fontFeatureSettings
set on a Text elementWhat are the steps to reproduce (after prerequisites)?
fontFeatureSettings
is not appliedfontFeatureSettings
is applied properlyCompatibility
Checklist
README.md
__tests__
folder