Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support fontFeatureSettings on web #2463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qwertychouskie
Copy link

Summary

Support is just a matter of making sure we pass through the value properly. Hopefully the property is supported on iOS soon, but for now, 2 (Android + web) out of 3 is better than 1 out of 3.

Test Plan

Ran change locally, worked fine. It's a pretty trivial change.

What's required for testing (prerequisites)?

An SVG with fontFeatureSettings set on a Text element

What are the steps to reproduce (after prerequisites)?

  1. Open browser
  2. See that fontFeatureSettings is not applied
  3. Apply this change
  4. See that fontFeatureSettings is applied properly

Compatibility

OS Implemented
iOS
MacOS
Android
Web

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

Support is just a matter of making sure we pass through the value properly.
@bohdanprog
Copy link
Member

bohdanprog commented Sep 25, 2024

Hello @qwertychouskie,
Thank you for your involvement in developing the library.
Could you please provide an example of how we can check if it works?
Here is my example where I tried to check how it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants