Add correct invalidate calls to SvgView on ios with test #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Kicu
force-pushed
the
kicu/fix-svguri-newarch
branch
from
d8c772e
to
5c3678c
Compare
github-merge-queue bot
referenced
this pull request
in valora-inc/wallet
Aug 5, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-svg](https://togithub.com/react-native-community/react-native-svg) | [`^15.3.0` -> `^15.4.0`](https://renovatebot.com/diffs/npm/react-native-svg/15.3.0/15.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>react-native-community/react-native-svg (react-native-svg)</summary> ### [`v15.4.0`](https://togithub.com/software-mansion/react-native-svg/releases/tag/v15.4.0) [Compare Source](https://togithub.com/react-native-community/react-native-svg/compare/v15.3.0...v15.4.0) Introducing the long-awaited filters in react-native-svg! 🎉 This minor release includes the first filter, FeColorMatrix, along with numerous fixes and other improvements. #### What's Changed - fix: error when building paper after fabric by [@​maciekstosio](https://togithub.com/maciekstosio) in [https://github.com/software-mansion/react-native-svg/pull/2281](https://togithub.com/software-mansion/react-native-svg/pull/2281) - Handle error when pass wrong uri to SvgFromUri component by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2289](https://togithub.com/software-mansion/react-native-svg/pull/2289) - chore: TestsExample app fix reanimated and metro.config issues by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2291](https://togithub.com/software-mansion/react-native-svg/pull/2291) - chore: remove macos-build-test.yml by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2292](https://togithub.com/software-mansion/react-native-svg/pull/2292) - chore: add hire us section to readme by [@​kacperkapusciak](https://togithub.com/kacperkapusciak) in [https://github.com/software-mansion/react-native-svg/pull/2295](https://togithub.com/software-mansion/react-native-svg/pull/2295) - feat: github action close-when-stale by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2296](https://togithub.com/software-mansion/react-native-svg/pull/2296) - fixed pars on Android platform prop strokeDasharray by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2294](https://togithub.com/software-mansion/react-native-svg/pull/2294) - feat: add new bug issue template, and github actions by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2300](https://togithub.com/software-mansion/react-native-svg/pull/2300) - fix: issue template by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2301](https://togithub.com/software-mansion/react-native-svg/pull/2301) - fix: example app package.json file and yarn.lock by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2303](https://togithub.com/software-mansion/react-native-svg/pull/2303) - fix: handle onPress prop on web app by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2302](https://togithub.com/software-mansion/react-native-svg/pull/2302) - fix: android PathParser crash app if pass some wrong d prop by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2308](https://togithub.com/software-mansion/react-native-svg/pull/2308) - fix: scaling when mask is set by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2299](https://togithub.com/software-mansion/react-native-svg/pull/2299) - add onLoad prop to Image component by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2293](https://togithub.com/software-mansion/react-native-svg/pull/2293) - feat: update needs-more-info git workflow by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2314](https://togithub.com/software-mansion/react-native-svg/pull/2314) - fix: new arch invalidate on mount/unmount by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2318](https://togithub.com/software-mansion/react-native-svg/pull/2318) - Fix: image onLoad props by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2317](https://togithub.com/software-mansion/react-native-svg/pull/2317) - feat(windows): add support for 74 and bump Example by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/2315](https://togithub.com/software-mansion/react-native-svg/pull/2315) - feat: add Example Windows build workflow by [@​marlenecota](https://togithub.com/marlenecota) in [https://github.com/software-mansion/react-native-svg/pull/2322](https://togithub.com/software-mansion/react-native-svg/pull/2322) - fix: add check in RNSVGImage for macos platform by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2324](https://togithub.com/software-mansion/react-native-svg/pull/2324) - Add correct invalidate calls to SvgView on ios with test by [@​Kicu](https://togithub.com/Kicu) in [https://github.com/software-mansion/react-native-svg/pull/2327](https://togithub.com/software-mansion/react-native-svg/pull/2327) - fix: extract opacity use percentage values by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2325](https://togithub.com/software-mansion/react-native-svg/pull/2325) - feat: change folders structure by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2319](https://togithub.com/software-mansion/react-native-svg/pull/2319) - Implement mask-type property by [@​SergeyYurkevich](https://togithub.com/SergeyYurkevich) in [https://github.com/software-mansion/react-native-svg/pull/2152](https://togithub.com/software-mansion/react-native-svg/pull/2152) - feat: extract web example by [@​bohdanprog](https://togithub.com/bohdanprog) in [https://github.com/software-mansion/react-native-svg/pull/2333](https://togithub.com/software-mansion/react-native-svg/pull/2333) - fix: macos mask by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2337](https://togithub.com/software-mansion/react-native-svg/pull/2337) - fix: fix format-js task to reflect changes made to folder structure by [@​CDFN](https://togithub.com/CDFN) in [https://github.com/software-mansion/react-native-svg/pull/2342](https://togithub.com/software-mansion/react-native-svg/pull/2342) - Add missing `#include <folly/dynamic.h>` on RN 0.75 by [@​tomekzaw](https://togithub.com/tomekzaw) in [https://github.com/software-mansion/react-native-svg/pull/2344](https://togithub.com/software-mansion/react-native-svg/pull/2344) - feat: filters support FeColorMatrix and FilterImage by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2316](https://togithub.com/software-mansion/react-native-svg/pull/2316) - fix: mask and filters rendering issues by [@​jakex7](https://togithub.com/jakex7) in [https://github.com/software-mansion/react-native-svg/pull/2345](https://togithub.com/software-mansion/react-native-svg/pull/2345) #### New Contributors - [@​maciekstosio](https://togithub.com/maciekstosio) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2281](https://togithub.com/software-mansion/react-native-svg/pull/2281) - [@​bohdanprog](https://togithub.com/bohdanprog) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2289](https://togithub.com/software-mansion/react-native-svg/pull/2289) - [@​Kicu](https://togithub.com/Kicu) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2327](https://togithub.com/software-mansion/react-native-svg/pull/2327) - [@​SergeyYurkevich](https://togithub.com/SergeyYurkevich) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2152](https://togithub.com/software-mansion/react-native-svg/pull/2152) - [@​CDFN](https://togithub.com/CDFN) made their first contribution in [https://github.com/software-mansion/react-native-svg/pull/2342](https://togithub.com/software-mansion/react-native-svg/pull/2342) **Full Changelog**: software-mansion/react-native-svg@v15.3.0...v15.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJucG0iLCJyZW5vdmF0ZSJdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <[email protected]> Co-authored-by: Alex Bakoushin <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a sibling PR to: #2318 which fixed missing mount/unmount methods to correctly display SVG.
This PR overrides the same
mountChildComponentViewandunmountChildComponentViewmethods but forRNSVGSvgViewcomponent. This will make the components and their behaviour aligned and more predictable.I included the test that specifically tests for attaching another external svg into and already existing SVG, should catch any edge cases with invalidation/redrawing.
Test Plan
TestExampleapp ->TestSvgUriUpdatingexample.rec-svg-ios.mov
Compatibility
Checklist
README.md__tests__folder