fix: restore bitmap recycling on children changes #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2022
maxoschepkov
approved these changes
Sep 10, 2022
|
@WoLewicki any idea when this become available via new NPM version? |
|
@WoLewicki Second on the request to release into a new version asap please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR fixing the regression introduced in #1844. In that PR we set
mRemovedFromReactViewHierarchyafter one ofSvgView's children has been removed, resulting in not being able to update it after one of the components in its hierarchy has been removed. In this PR the behavior has been changed, now we subscribe tostartViewTransitionwhich should be called only byreact-native-screenswhen the screen starts its removal animation. It should still work for old issues as well as the new ones.Fix originally proposed by @msvargas in software-mansion/react-native-screens#773 (comment).
Test Plan
software-mansion/react-native-screens#773 (comment)
#1859
#1861